Add CI for e2e #208
Add CI for e2e #208
Conversation
Set up CI for e2e
| then | ||
| echo "FROM opendistroforelasticsearch/opendistroforelasticsearch:$version" >> Dockerfile | ||
| ## The ESRestTest Client uses http by default. | ||
| ## Need to disable the security plugin to call the rest api over http. |
There was a problem hiding this comment.
Thanks for the change, very helpful. The workflow looks good.
Is it possible to test with security plugin enabled? No need to answer or change this PR if no clear answer now. We can create issue and research later.
Asking this as start detector REST API will start AD job. We'd better test with security plugin enabled to know if AD job can run successfully, generate AD result and show the result correctly on Kibana.
There was a problem hiding this comment.
That's a good point. I created issue: #209
| - name: Checkout Kibana | ||
| uses: actions/checkout@v2 | ||
| with: | ||
| repository: elastic/kibana |
There was a problem hiding this comment.
Let's hold for some time for response of using elastic/kibana or kibana oss. Similar to this one #207
|
How about we change this to just run on pushes to master for now so we can merge and start using cypress? |
Totally agree. No clear reply yet. We don't need to wait for the decision. Can add PR triggered test workflow later. |
Sure. I will use private repo and change to only run it on pushes to master. |
|
Will verify the change after this is merged |
Description of changes:
Set up CI for e2e.
Basic workflow:
Latest E2E run history is here: #203
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.